Skip to content

chore: use a central code location to check PHP version#41005

Merged
phil-davis merged 2 commits intomasterfrom
chore/central-php-version-check
Oct 3, 2023
Merged

chore: use a central code location to check PHP version#41005
phil-davis merged 2 commits intomasterfrom
chore/central-php-version-check

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 2, 2023

Description

Some refactoring as part of the work related to #40981

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 force-pushed the chore/central-php-version-check branch from 34802a6 to 5e335ae Compare October 2, 2023 15:06
phil-davis
phil-davis reviewed Oct 2, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 5 Security Hotspots
Code Smell A 45 Code Smells

3.9% 3.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@phil-davis phil-davis self-requested a review October 3, 2023 01:25
@phil-davis phil-davis merged commit 91bae61 into master Oct 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the chore/central-php-version-check branch October 3, 2023 01:29
@owncloud owncloud deleted a comment from update-docs bot Oct 3, 2023
@phil-davis
Copy link
Contributor

phil-davis commented Oct 3, 2023 

$ php occ a:l -e
This version of ownCloud is not compatible with PHP 8.0
You are currently running PHP 8.1.23.

It is not compatible with PHP 8.0 or later, but I suppose that the message is OK - people should be able to work out that PHP 8.1... is also not going to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DeepDiver1975 @phil-davis